Skip to content

Fix #2391: Make child annotation lazy #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2017
Merged

Fix #2391: Make child annotation lazy #2392

merged 1 commit into from
May 8, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented May 8, 2017

Make child annotations compute their symbols lazily when
unpickling from Scala2.

@odersky
Fix scala#2391: Make child annotation lazy
3fca1a8 
Make child annotations compute their symbols lazily when
unpickling from Scala2
@odersky odersky requested a review from felixmulder May 8, 2017 13:02
felixmulder
felixmulder approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@felixmulder felixmulder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for future tests of this nature - we could provide some form of convention to be able to compile things first with scala2 and then dotty. But I'm not sure that will be beneficial if we cannot maintain binary compat anyway.

@felixmulder felixmulder merged commit 4c8a950 into scala:master May 8, 2017
@allanrenucci allanrenucci deleted the fix-#2391 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixmulder felixmulder felixmulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @felixmulder