Skip to content

Make bot check contributors before sending heart-warming greeting #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2017
Merged

Make bot check contributors before sending heart-warming greeting #2384

merged 2 commits into from
May 6, 2017

Conversation

felixmulder
Copy link
Contributor

No description provided.

@felixmulder felixmulder requested a review from smarter May 6, 2017 08:58
dottybot
dottybot reviewed May 6, 2017
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

If you haven't already, please request a review from one of our
collaborators (have no fear, we don't bite)!

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@felixmulder felixmulder force-pushed the topic/make-bot-check-contribs branch from 0d7a550 to 7f0e20e Compare May 6, 2017 09:00
@odersky odersky self-requested a review May 6, 2017 09:36
odersky
odersky approved these changes May 6, 2017
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixmulder felixmulder force-pushed the topic/make-bot-check-contribs branch from 7f0e20e to 6f49d6f Compare May 6, 2017 09:42
@felixmulder felixmulder merged commit e4e4810 into scala:master May 6, 2017
@smarter
Copy link
Member

smarter commented May 6, 2017

@felixmulder That's not enough in my opinion, even external contributors shouldn't be spammed by the same message from the bot for every single PR they make, they will get annoyed very quickly. The bot should never send the same greeting message twice to a single person. Maybe you could use the github "first-time contributor" mark if it's accessible from the API.

@felixmulder
Copy link
Contributor Author

@smarter - this PR makes the bot check if the person who authored the PR is amongst the people in https://github.com/lampepfl/dotty/graphs/contributors. Which means, once they've had a PR merged, they will not be greeted by the bot unless they've made some mistake that the bot finds.

@felixmulder
Copy link
Contributor Author

If you think it should be more strict, you're welcome to take a crack at it. But it's Saturday - so I'm off duty.

@smarter
Copy link
Member

smarter commented May 6, 2017

Ah I see, then that should be ok.

@allanrenucci allanrenucci deleted the topic/make-bot-check-contribs branch December 14, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@odersky odersky odersky approved these changes

@smarter smarter Awaiting requested review from smarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixmulder @smarter @odersky @dottybot