Fix strawman compilation v2 #2372
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
If you haven't already, please request a review from one of our
collaborators (have no fear, we don't bite)!
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Added" instead of "Add")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
It should not happen that we need to turn signed names into strings. But it did because of the bug that was fixed in the previous commit. Anyway, toString is the wrong place to get picky about what should or should not have happened.
This was accidentally left in the code, was intended only for debugging.
odersky
force-pushed
the
fix-strawman-compile-2
branch
from
b927d91 to
1a00fe6
Compare
|
I give up. I tried rebase + git submodule several times. No avail. Why are we doing this? |
|
@nicolasstucki @smarter Can one of you please take over this branch and make it pass the CI? Thanks! |
|
Here's some more info: /Users/odersky/workspace/dotty> git submodule update --init |
|
I've removed the |
| chapter: 13 | ||
| --- | ||
|
|
||
| # Syntax Summary |
There was a problem hiding this comment.
This seems to be copy-paste from scalac, and to duplicate the existing syntax.md. Did you intend to add this file?
There was a problem hiding this comment.
No, that was a mistake. I'll remove it.
|
PR is now green :). |
|
Thanks for the fix, @smarter! The spurious scala-scala submodule started showing up in my git status, I believe it was after scala-library was added. I thought I needed to push it like the others. No idea why it showed up suddenly - I did not touch the directory for a while. |
odersky
force-pushed
the
fix-strawman-compile-2
branch
from
89946e9 to
f47ef9a
Compare
|
@odersky If you still have a |
|
@smarter Good to know! |
Some more fixes related to making the latest version of the strawman (and some random variations) compile under dotty.