Fix #2232: Don't check AndTypes in liftToClasses #2329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of liftToClasses is just to aggregate two types into one. No attempt at checking well-formedness is necessary.
smarter
reviewed
Apr 28, 2017
| /** Make an AndType using `op` unless clearly unnecessary (i.e. without | ||
| * going through `&`). | ||
| */ | ||
| def make(tp1: Type, tp2: Type, op: (Type, Type) => AndType)(implicit ctx: Context): Type = |
There was a problem hiding this comment.
Is a lambda really necessary here? I would have gone with a checkWellFormedness: Boolean = true parameter instead, creating closures in derivedAndType seems wasteful.
Use a boolean instead of a lambda for efficiency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of liftToClasses is just to aggregate two
types into one. No attempt at checking well-formedness
is necessary.