Only keep denotation for methods in IntegrateMap #23226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
May 21, 2025
There was a problem hiding this comment.
LGTM. Since methods won't show up outside of annotations this shouldn't break anything else, but it seems a bit unprincipled, I guess to be really safe we should rework LambdaType so the paramInfos array is filled lazily as each argument is typed, but that would be a tricky refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23217.
Similarly to #23056, the issues occurs in a situation where the denotation should be reloaded during
integrateand is not. The fix is to further tighten the condition to preserve the denotation, preserving it only when the symbol is a method.