Skip to content

Change backend name handling #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 28, 2017
Merged

Change backend name handling #2322

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8775dd1
Drop internalNameString and hava javaBinaryName return a string
odersky Apr 27, 2017
ca46e49
Drop unused operations in NameHandler
odersky Apr 27, 2017
4641bf2
Remove more name ops
odersky Apr 27, 2017
2c4ac2c
[TO BE REVERTED] Gross hack to work around leaky NameHelper abstraction
odersky Apr 4, 2017
0735a68
Use mangled string in backend
odersky Apr 27, 2017
b28f766
Change some
odersky Apr 28, 2017
d7eea41
Change some toString occurrences on Name to mangledString
odersky Apr 28, 2017
c3cc84f
Document name checking
odersky Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compiler/src/dotty/tools/dotc/core/Names.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,10 @@ object Names {
else {
if (Config.checkBackendNames) {
if (!toStringOK) {
// We print the stacktrace instead of doing an assert directly,
// because asserts are caught in exception handlers which might
// cause other failures. In that case the first, important failure
// is lost.
println("Backend should not call Name#toString, Name#mangledString should be used instead.")
Copy link
Member

@smarter smarter Apr 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Console.err.println (or System.err.println) instead. printStackTrace will print on stderr, and if you use println right before it which prints on stdout, the output might get mixed.

new Error().printStackTrace()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicer way: Thread.dumpStack()

assert(false)
Expand All @@ -301,6 +305,9 @@ object Names {
new String(chrs, start, length)
}

/** It's OK to take a toString if the stacktrace does not occur a method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "a method" -> "in a method"
And on the line below: "or it also" -> "or if it also"

* in GenBCode or it also contains one of the whitelisted methods below.
*/
private def toStringOK = {
val trace = Thread.currentThread.getStackTrace
!trace.exists(_.getClassName.endsWith("GenBCode")) ||
Expand Down