[Vulpix] Abort compilation after maxCompileTime
#2318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a very misleading change. |
|
Additionally, it blocks the compilation thread and instead uses global future threadpool, ie the number of compilation threads is not controlled using previous means anymore |
|
Non-constructive feedback. Please rephrase. |
|
While I agree that I could have phrased it differently, I find a sneaky way of putting such changes without documenting them very misleading, hence my reaction. Constructive version of it was in the original #2125 PR. |
|
Fair enough 😃 let's do this properly then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.