Remove ProductN parent on case classes #2314
Conversation
|
I think productElement/productArity should be added in SyntheticMethods instead of desugaring. Drone only caught that with |
|
Please investigate and add a meta test :) |
|
I agree; it would be more logical to add the methods in SyntheticMethods. Indeed we do have code there that adds productArity. productElement is missing, though. |
This means the compiler needs to systematically synthesise productElement and productArity, which aligns with what scalac is doing. This change gets rid of last reference to scala.ProductN! 🎉
The implementation needed changes since Desugaring uses `untpd._` while SyntheticMethods uses `tpd._`. `productArity` is also removed from Desugaring, it's already implement in SyntheticMethods, so no changes there.
OlivierBlanvillain
force-pushed
the
no-product-n
branch
from
f5a7f6b to
df39a40
Compare
| val ioob = defn.IndexOutOfBoundsException.typeRef | ||
| // That's not ioob.typeSymbol.primaryConstructor, this is the other one | ||
| // that takes a String argument. | ||
| val constructor = ioob.typeSymbol.info.decls.toList.tail.head.asTerm |
There was a problem hiding this comment.
It would be better if you didn't rely on the order of declarations and instead filtered the declarations to only include the one that you want.
| // Second constructor of ioob that takes a String argument | ||
| def filterStringConstructor(s: Symbol): Boolean = s.info match { | ||
| case m: MethodType if s.isConstructor => m.paramInfos == List(defn.StringType) | ||
| case _ => false |
There was a problem hiding this comment.
I think there's an easier way to get this, but I'll play with it and do it in a different PR.
There was a problem hiding this comment.
IndexOutOfBoundsException contains two declarations, its primary constructor (which takes not argument), and this other constructor that takes a String. I first did .decls.toList.tail.head, then changed it to this very precise filter, do you have something in between?
This means the compiler needs to systematically synthesise productElement and
productArity, which aligns with what scalac is doing.
This change gets rid of last reference to
scala.ProductN! 🎉