Add seconds to log timestamps to avoid log name clashes. #2280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-tests-logs-overwritten
branch
from
0338d60 to
5d8a57b
Compare
felixmulder
approved these changes
Apr 20, 2017
DarkDimius
reviewed
Apr 20, 2017
| val date = new Date | ||
| val df0 = new SimpleDateFormat("yyyy-MM-dd") | ||
| val df1 = new SimpleDateFormat("yyyy-MM-dd-HH:mm:ss") | ||
| val folder = s"../testlogs/tests-${df0.format(date)}" |
There was a problem hiding this comment.
- if tests run in parallel, you can have two tests that start at the same second.
- I would prefer to have names of the log-files that are predictable.
There was a problem hiding this comment.
This is intended as a quick fix. There are many possible improvements that should be done on these logs.
|
I agree with Nicolas, in the end this is an improvement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.