Only ignore inlined if conditions if pure. #2264
Conversation
Idempotent ones could have a side effect.
| @@ -527,7 +527,7 @@ class Inliner(call: tpd.Tree, rhs: tpd.Tree)(implicit ctx: Context) { | |||
| cond1.tpe.widenTermRefExpr match { | |||
| case ConstantType(Constant(condVal: Boolean)) => | |||
| val selected = typed(if (condVal) tree.thenp else tree.elsep, pt) | |||
| if (isIdempotentExpr(cond1)) selected | |||
| if (isPureExpr(cond1)) selected | |||
There was a problem hiding this comment.
In fact it looks like all constant type conditions that reach this code are pure. Are they all supposed to be in this particular case? If not how could I construct a condition that has a constant type and is not pure.
There was a problem hiding this comment.
I think code should be transformed in a different way instead(That's what is done in linker):
if ($cond: true.type) { $themp } else { $elsep }
==>>
cond$;
thenp$Similar for false.type .
There was a problem hiding this comment.
In fact it looks like all constant type conditions that reach this code are pure. Are they all supposed to be in this particular case?
lazy val s: true = { println(1); true}
@inline def bla =
if (s) {...} else {...}
There was a problem hiding this comment.
That lazy val creates the idempotent condition with constant type. Just found another bug with lazy vals with constant type #2266.
|
Deferring for now. Awaiting effects system :) |
Idempotent ones could have a side effect.