Fix #2219: Fix type applications on WildcardType #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
reviewed
Apr 11, 2017
| @@ -429,7 +429,7 @@ class TypeApplications(val self: Type) extends AnyVal { | |||
| case dealiased: LazyRef => | |||
| LazyRef(() => dealiased.ref.appliedTo(args)) | |||
| case dealiased: WildcardType => | |||
| dealiased | |||
| WildcardType(dealiased.optBounds.appliedTo(args).asInstanceOf[TypeBounds]) | |||
There was a problem hiding this comment.
You can just write .bounds instead of .asInstanceOf[TypeBounds]).
Previously we just returned the unapplied WildcardType which is incorrect if the WildcardType is bounded. The proper thing to do is to do the type application on the bounds of the WildcardType and wrap the result in a WildcardType.
smarter
force-pushed
the
fix/wildcard-apply
branch
from
115cffe to
ad6c683
Compare
|
One of the stupid benchmark-as-test failed, merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we just returned the unapplied WildcardType which is
incorrect if the WildcardType is bounded. The proper thing to do is to
do the type application on the bounds of the WildcardType and wrap the
result in a WildcardType.