Skip to content

Fix #2142: Skolemize arguments of dependent methods if necessary #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2017
Merged

Fix #2142: Skolemize arguments of dependent methods if necessary #2215

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
529346d
Handle printing of term paramrefs
odersky Apr 10, 2017
b3d683a
Explain skolem types
odersky Apr 10, 2017
bb0faff
Skolemize arguments to dependent methods as necessary.
odersky Apr 10, 2017
ab06e2d
Generalize definition of Type#isStable
odersky Apr 10, 2017
0cf17c5
Align safe parameter substitution with other subst methods
odersky Apr 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler/src/dotty/tools/dotc/core/Types.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,11 @@ object Types {
final def isValueTypeOrLambda: Boolean = isValueType || this.isInstanceOf[TypeLambda]

/** Does this type denote a stable reference (i.e. singleton type)? */
@tailrec final def isStable(implicit ctx: Context): Boolean = stripTypeVar match {
case tp: TermRef => tp.termSymbol.isStable && tp.prefix.isStable
final def isStable(implicit ctx: Context): Boolean = stripTypeVar match {
case tp: TermRef => tp.termSymbol.isStable && tp.prefix.isStable || tp.info.isStable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change also needed to make a test pass? It seems more suspicious.

Copy link
Contributor Author

@odersky odersky Apr 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pos/z1720 started failing without the fix. The commit comment indicates this.

case _: SingletonType | NoPrefix => true
case tp: RefinedOrRecType => tp.parent.isStable
case tp: ExprType => tp.resultType.isStable
case _ => false
}

Expand Down