Skip to content

[CI] trigger library tests on cc changes #22055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[CI] trigger library tests on cc changes #22055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f25f88
[CI] trigger library tests on cc changes
bracevac Nov 29, 2024
03b8368
dummy change
bracevac Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,13 @@ jobs:
github.event_name == 'pull_request'
&& contains(github.event.pull_request.body, '[test_scala2_library_tasty]')
)
|| (
github.event_name == 'pull_request'
&& ( contains(github.event.pull_request.changed_files, 'scala2-library-cc/')
|| contains(github.event.pull_request.changed_files, 'scala2-library-cc-tasty/')
|| contains(github.event.pull_request.changed_files, 'compiler/src/dotty/tools/dotc/cc/')
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also include capture test folders.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this, but why would that be necessary? I don't see how changing the capture tests could affect the outcome of the standard library tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure the modified/added test has the same behaviour/output with the two versions of stdlib.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: Speaking of capture tests: they are spread out throughout the tests folder, according to grep -nHr captureChecking ./tests. Should we put them under a central folder? @odersky

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PPS: Those specific lines in the yaml file do not appear to work as intended. ChatGPT lied to me 😢

)
|| (
github.event_name == 'workflow_dispatch'
&& github.repository == 'scala/scala3'
Expand Down
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/cc/CaptureSet.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import CCState.*
/** A class for capture sets. Capture sets can be constants or variables.
* Capture sets support inclusion constraints <:< where <:< is subcapturing.
*
*
* They also allow
* - mapping with functions from elements to capture sets
* - filtering with predicates on elements
Expand Down
Loading