Refactor/def trees #220
Merged
Refactor/def trees #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed MemberDef trees now take the modifiers from their symbol's data.
withMods should never be used to produce a typed tree, because typed member defs get their modifiers from their symbols.
|
Otherwise LGTM |
odersky
force-pushed
the
refactor/DefTrees
branch
from
ceed083 to
5bf6bfb
Compare
|
Force pushed last commit, which missed an import before. |
odersky
force-pushed
the
refactor/DefTrees
branch
from
5bf6bfb to
cd2f99c
Compare
|
@DarkDimius can you have a look at the last commit (should be non-controversial) and merge if LGTY? |
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
May 8, 2025
Backport "Fix stack overflow errors when generating opaque type proxies" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid redundancy between mods in trees and equivalent symbol information. Review by @DarkDimius