-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #2156 #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix #2156 #2158
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
88bac0e
Fix #2165, emit outerChecks on ThisType
DarkDimius c5031a7
PatMat: get rid of unnecessary forwarder
DarkDimius e901310
PatMat, Outerchecks: Check outers for selections from singleton type.
DarkDimius 8a0c3c4
Test that #2156 is fixed
DarkDimius 03f1304
Fix a bug(I guess?) hidden by scalac sometimes not emitting outer checks
DarkDimius f370799
Fix ClassfileParser
odersky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
class Outer { | ||
|
||
case class Inner() | ||
|
||
val inner: Inner = new Inner | ||
|
||
def checkInstance(o: Outer) = | ||
o.inner.isInstanceOf[this.Inner] | ||
|
||
def checkPattern1(i: Any) = | ||
i match { | ||
case _: Inner => true | ||
case _ => false | ||
} | ||
|
||
def checkPattern2(i: Any) = | ||
i match { | ||
case Inner() => true | ||
case _ => false | ||
} | ||
|
||
def checkEquals(o: Outer) = | ||
o.inner == inner | ||
} | ||
|
||
object Test { | ||
|
||
def main(args: Array[String]) = { | ||
val o1 = new Outer | ||
val o2 = new Outer | ||
assert(o1.checkInstance(o2)) // ok | ||
assert(!o1.checkPattern1(o2.inner)) // ok under scalac, fails for dotc-compiled code | ||
assert(!o1.checkPattern2(o2.inner)) // ok under scalac, fails for dotc-compiled code | ||
assert(!o1.checkEquals(o2)) // ok under scalac, fails for dotc-compiled code | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the added definition of
s
. Just usetref
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variables defined in pattern matches are rarely debuggable when compiled by scalac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, if you prefer.