Skip to content

Fix #2151: don't die for wrong number of typeargs applied #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2017

Conversation

felixmulder
Copy link
Contributor

No description provided.

@felixmulder felixmulder requested a review from smarter March 30, 2017 15:34
@smarter
Copy link
Member

smarter commented Mar 30, 2017

ERROR: terminal inactive for 10m0s, build cancelled

Looks like 10 minutes for the run tests is not enough.

@felixmulder
Copy link
Contributor Author

Looks like we have a spurious error of some kind, will investigate tomorrow.

@@ -12,7 +12,7 @@ import scala.util.matching.Regex
class CompilationTests extends ParallelSummaryReport with ParallelTesting {
import CompilationTests._

def isInteractive: Boolean = ParallelSummaryReport.isInteractive
def isInteractive: Boolean = false//ParallelSummaryReport.isInteractive
Copy link
Member

@smarter smarter Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what.

}
}
rep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a link to the corresponding bug report if you open one

@felixmulder felixmulder merged commit d73c8e4 into scala:master Mar 31, 2017
@allanrenucci allanrenucci deleted the topic/fix-#2151 branch December 14, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants