Enable incremental compilation scripted tests on CI #2141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
add/ci-sbt-tests
branch
from
1e5cb9f to
cbfb3be
Compare
This wasn't enabled before because these tests take a long time, but thanks to sbt/sbt#3015 scripted tests can now manually be splitted in M groups of equal size using the "/*NofM" syntax.
smarter
force-pushed
the
add/ci-sbt-tests
branch
from
cbfb3be to
5e98c5a
Compare
|
@felixmulder The scripted test runs each take ~20 minutes when the JUnit tests take ~24 minutes, so we should be able to turn them on without making the CI slower. If the CI has a configuration option for maximum number of jobs run in parallel, it should be increased. |
|
The new parallel test suite runs in ~12 minutes - but I think by tweaking the memory given to each sbt instance we can decrease that time further. So perhaps it would be a good idea to split these further - or add them as conditional tests that are only run when the PR is merged to master? |
|
Okay, I guess we wait until your stuff is merged and re-evaluate then. |
|
We've decided to put this into nightly tests. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't enabled before because these tests take a long time, but
thanks to sbt/sbt#3015 scripted tests can now
manually be splitted in M groups of equal size using the "/*NofM" syntax.