Skip to content

Add a warning and instructions for new users. #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

This is a small check to make sure users haven't forgotten to clone the scala-scala library. It contributes to solving #2132

println(
s"""[WARNING] Missing `dotty/scala-scala` library
|You can clone the library with:
| > git clone https://github.com/DarkDimius/scala.git ${scalaScala.getAbsolutePath}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it in one line with git clone -b, see http://dotty.epfl.ch/docs/contributing/workflow.html

@nicolasstucki nicolasstucki force-pushed the add-warning-on-missin-scala-scala branch from d834bcc to 598705e Compare March 23, 2017 14:34
@olhotak
Copy link
Contributor

olhotak commented Mar 23, 2017

Is cloning scala-scala something that is going to be a requirement for a long time?

If so, it should also be added to docs/docs/contributing/getting-started.md.

@nicolasstucki
Copy link
Contributor Author

@olhotak issue #2132 is about adding it to the documentation. This is just a small safeguard.

Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do as @OlivierBlanvillain suggests in #2132 and remove this weirdness all together.

Merging this is fine by me - but it should be reverted if we go ahead with including scala-library as integration tests in ./tests/old-scala-library

@DarkDimius
Copy link
Contributor

Merging as this is clearly better then current state.
I disagree with putting entire stdlib in ./tests/
I believe we should have it as a git submodule.

@DarkDimius DarkDimius merged commit 1fe7304 into scala:master Mar 28, 2017
@smarter
Copy link
Member

smarter commented Mar 28, 2017

I also think it would make sense to have it as a submodule if we get the backend as a submodule anyway.

@allanrenucci allanrenucci deleted the add-warning-on-missin-scala-scala branch December 14, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants