Fix incremental compilation not working after restarting sbt #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, every time sbt was restarted, `compile` would do a full recompilation. This happened because sbt uses Java serialization to persist the incremental compilation analysis, deserialization was always silently failing because we used to serialize a class from the dotty-compiler jar which is not on the classpath at deserialization time. See the added comments for more details.
smarter
force-pushed
the
fix/incremental-compilation-restart
branch
from
ff57450 to
16ce4f7
Compare
felixmulder
approved these changes
Mar 22, 2017
There was a problem hiding this comment.
Changes look good to me. It is an interesting solution, and it obviously works. But I still feel like we shouldn't be integrating sbt into Dotty, it should be the other way around.
This being said - to get incremental compilation to work without spending loads of time by contributing to sbt - this is the most pragmatic solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every time sbt was restarted,
compilewould do a fullrecompilation. This happened because sbt uses Java serialization to
persist the incremental compilation analysis, deserialization was always
silently failing because we used to serialize a class from the
dotty-compiler jar which is not on the classpath at deserialization
time. See the added comments for more details.