Skip to content

Backport "Better error diagnostics for cyclic references" to LTS #20824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2024
Merged

Backport "Better error diagnostics for cyclic references" to LTS #20824

merged 3 commits into from
Jun 28, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #19408 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

odersky added 3 commits June 27, 2024 11:29
@odersky @WojciechMazur
Better error diagnostics for cyclic references
d673901 
We now suggest to compile with -explain-cyclic, in which case we
give a trace of the forcings that led to the cycle.

The reason for the separate option is that maintaining a trace is not
free so we should not be doing it by default.

[Cherry-picked d2becfe]
@odersky @WojciechMazur
Update compiler/src/dotty/tools/dotc/core/SymDenotations.scala
55fa46d 
[Cherry-picked ce27de2]
@odersky @WojciechMazur
Update check files to new error message wording
770481e 
[Cherry-picked 1f683cc]
Base automatically changed from lts-19410 to lts-18702 June 28, 2024 10:08
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-19520.

Reference

@WojciechMazur WojciechMazur merged commit 6d207ab into lts-18702 Jun 28, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-19408 branch June 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @odersky