Drop named type parameters in classes #2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the [type T] syntax, and what's associated to make it work. Motivation: It's an alternative way of doing things for which there seems to be little need. The implementation was provisional and bitrotted during the various iterations to introduce higher-kinded types. So in the end the complxity-cost for language and compiler was not worth the added benefit that [type T] parameters provide. Noe that we still accept _named arguments_ [A = T] in expressions; these are useful for specifying some parameters and letting others be inferred.
smarter
approved these changes
Mar 5, 2017
| val mod = atPos(in.skipToken()) { Mod.Type() } | ||
| (mods | Param | ParamAccessor).withAddedMod(mod) | ||
| } else { | ||
| if (mods.hasFlags) syntaxError(TypeParamsTypeExpected(mods, ident())) |
There was a problem hiding this comment.
The message TypeParamsTypeExpected is now unused and could be removed.
|
https://github.com/lampepfl/dotty/blob/master/compiler/test/dotty/tools/dotc/parsing/ModifiersParsingTest.scala#L99 needs to be updated to remove the use of named types. |
Deleting an error message changes all subsequent error message umbers, which means that REPL tests were invalidated. This is a bit unfortunate from a testing standpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the [type T] syntax, and what's associated to make it work.
Motivation: It's an alternative way of doing things for which there seems
to be little need. The implementation was provisional and bitrotted during
the various iterations to introduce higher-kinded types. So in the end the
complxity-cost for language and compiler was not worth the added benefit
that [type T] parameters provide.
Note that we still accept named arguments [A = T] in expressions; these are useful
for specifying some parameters and letting others be inferred.
Review by @smarter