Tailrec for derivesFrom/lookupRefined/classSymbol/classSymbols #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
reviewed
Mar 1, 2017
| case pre: RefinedType => | ||
| pre.refinedInfo match { | ||
| case TypeAlias(alias) => | ||
| if (pre.refinedName ne name) loop(pre.parent) else alias | ||
| case _ => loop(pre.parent) | ||
| } | ||
| case pre: RecType => | ||
| val candidate = loop(pre.parent) | ||
| val candidate = pre.parent.lookupRefined(name) |
There was a problem hiding this comment.
this change is not necessary. It will still get tail-rec optimized even without it.
You can use #1221 to mark per-callsite @tailrec-s
There was a problem hiding this comment.
Thanks, I used it in several places. In this instance it was easier to use the old notation.
DarkDimius
reviewed
Mar 1, 2017
| @@ -290,50 +290,56 @@ object Types { | |||
| * instance, or NoSymbol if none exists (either because this type is not a | |||
| * value type, or because superclasses are ambiguous). | |||
| */ | |||
| final def classSymbol(implicit ctx: Context): Symbol = this match { | |||
| case ConstantType(constant) => | |||
| constant.tpe.classSymbol | |||
There was a problem hiding this comment.
wasn't this already tailrec optimized?
Instead of rewriting by hand I suggest using #1221
nicolasstucki
force-pushed
the
tailrec-derivesFrom
branch
3 times, most recently
from
95db95a to
b3835b5
Compare
nicolasstucki
force-pushed
the
tailrec-derivesFrom
branch
from
b3835b5 to
be5720c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fist two commits make changes to loops, the third only adds
@tailrecannotations.