-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add fromNullable to Predef for explicit nulls #20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7291e54
to
077f60c
Compare
a0825c1
to
e55a36d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Nicolas Stucki <[email protected]>
sjrd
requested changes
May 1, 2024
The core meeting decided to take this PR in on 3.5.0. |
bishabosha
reviewed
May 1, 2024
sjrd
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:library
Standard library
area:nullability
needs-minor-release
This PR cannot be merged until the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attempt to enable explicit nulls for community projects has shown the usefulness of
fromNullable
,so we decide to include it in the std library.
It is a helper function which can turn a nullable value into an option.
The experimental issue (wait for #20260)
This PR is currently blocked by the experimental annotation: using the annotation in
Predef
would cause cyclic references when compiling the library.cc @olhotak