Fix warnings in sbt build #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
approved these changes
Feb 22, 2017
|
@smarter - seems like the partest command doesn't understand the parameters after these changes. Might need to make it into a key like the |
sjrd
reviewed
Feb 22, 2017
project/Build.scala
Outdated
| val scalaLib = attList | ||
| .map(_.data.getAbsolutePath) | ||
| .find(_.contains("scala-library")) | ||
| .toList.mkString(":") |
There was a problem hiding this comment.
You are dropping the dependency of this task on packageAll here. I guess this was not intentional. You should add
val _ = packageAll.value| @@ -327,7 +325,7 @@ object DottyBuild extends Build { | |||
| partestLockFile.createNewFile | |||
| partestLockFile.deleteOnExit | |||
| }, | |||
| runPartestRunner <<= Def.inputTaskDyn { | |||
| runPartestRunner := Def.inputTaskDyn { | |||
There was a problem hiding this comment.
If you change this, you also need to add .value after the closing } corresponding to the { on this line. This could explain the problem that you observe.
smarter
force-pushed
the
fix/sbt-warnings
branch
from
e5391b1 to
cf6c1d7
Compare
|
now we just need to migrate to |
smarter
force-pushed
the
fix/sbt-warnings
branch
from
cf6c1d7 to
d5fad45
Compare
|
Thanks @sjrd, @felixmulder , should be good know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.