Skip to content

added HashTableBuilder.rootNode to white list #19943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2024
Merged

added HashTableBuilder.rootNode to white list #19943

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e91006a
added Vector.emptyIterator to white list
Dan13llljws Mar 14, 2024
8a5cf8b
changed plain string to Definitions
Dan13llljws Mar 18, 2024
8315f78
changed to
Dan13llljws Mar 18, 2024
2a9f366
finalized whiteList
Dan13llljws Mar 25, 2024
c222381
Update compiler/src/dotty/tools/dotc/transform/init/Objects.scala
olhotak Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/init/Objects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,10 +1683,12 @@ class Objects:
end if

// class body
val whiteList = Set("scala.collection.immutable.Vector.emptyIterator")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a Definition here (from dotty.tools.dotc.core.Definitions) instead of a plain String, unless there is some reason not to.

tpl.body.foreach {
case vdef : ValDef if !vdef.symbol.is(Flags.Lazy) && !vdef.rhs.isEmpty =>
val res = eval(vdef.rhs, thisV, klass)
var res = eval(vdef.rhs, thisV, klass)
val sym = vdef.symbol
if (whiteList.contains(sym.showFullName)) res = Bottom
if sym.is(Flags.Mutable) then
val addr = Heap.fieldVarAddr(summon[Regions.Data], sym, State.currentObject)
thisV.initVar(sym, addr)
Expand Down