-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Don't allow implicit conversions on prefixes of type selections #19934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,8 @@ | ||
-- [E008] Not Found Error: tests/neg/i11994.scala:2:28 ----------------------------------------------------------------- | ||
2 |implicit def foo[T <: Tuple.meow]: Unit = ??? // error | ||
| ^^^^^^^^^^ | ||
| type meow is not a member of object Tuple. | ||
| Extension methods were tried, but the search failed with: | ||
| | ||
| Cyclic reference involving method foo | ||
| | ||
| The error occurred while trying to compute the signature of method foo | ||
| which required to compute the signature of type T | ||
| which required to compute the signature of method foo | ||
| | ||
| Run with both -explain-cyclic and -Ydebug-cyclic to see full stack trace. | ||
| type meow is not a member of object Tuple | ||
-- [E008] Not Found Error: tests/neg/i11994.scala:3:18 ----------------------------------------------------------------- | ||
3 |given [T <: Tuple.meow]: Unit = ??? // error | ||
| ^^^^^^^^^^ | ||
| type meow is not a member of object Tuple. | ||
| Extension methods were tried, but the search failed with: | ||
| | ||
| Cyclic reference involving method given_Unit | ||
| | ||
| The error occurred while trying to compute the signature of given instance given_Unit | ||
| which required to compute the signature of type T | ||
| which required to compute the signature of given instance given_Unit | ||
| | ||
| Run with both -explain-cyclic and -Ydebug-cyclic to see full stack trace. | ||
| type meow is not a member of object Tuple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
object Main{ | ||
object Foo | ||
object Bar{ type Qux = Unit } | ||
|
||
|
||
implicit def conv(f: Foo.type): Bar.type = Bar | ||
|
||
def B: Bar.type = Bar | ||
|
||
def main(args: Array[String]): Unit = { | ||
val x: Foo.Qux = null // error | ||
val y: B.Qux = null | ||
println(x) | ||
println(y) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.