Use enum for error messages IDs. #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarter check this out, @felixmulder told me that you had some opinions on the IDs. |
felixmulder
reviewed
Feb 16, 2017
| abstract class EmptyCatchOrFinallyBlock(tryBody: untpd.Tree, errNo: Int)(implicit ctx: Context) | ||
| extends Message(errNo) { | ||
| abstract class EmptyCatchOrFinallyBlock(tryBody: untpd.Tree, errNo: ErrorMessageID)(implicit ctx: Context) | ||
| extends Message(EmptyCatchOrFinallyBlockID) { |
There was a problem hiding this comment.
weird 4 space indentation here - let's get rid of that yes 😉
felixmulder
reviewed
Feb 16, 2017
nicolasstucki
force-pushed
the
error-messages-ids
branch
from
c2d0f97 to
eff2e07
Compare
|
5 years later.... just looking for a bit of clarity. Why are |
|
@ckipp01 it came from e42bb30#diff-e49722a882822c3e89863359a84e3431cc09a254b44dbed7d0914c75576003a9R93. Unfortunately this is not really useful.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.