-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix test directive in i18533 #19802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix test directive in i18533 #19802
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| -- Error: tests/neg/i18533/Non_SCALA_ONLY.java:4:7 --------------------------------------------------------------------- | ||
| 4 |public non class Test { // error | ||
| | ^^^ | ||
| | Identifier 'non' is not allowed here | ||
| -- Error: tests/neg/i18533/Pet_SCALA_ONLY.java:3:10 -------------------------------------------------------------------- | ||
| 3 |class Pet permits Cat { // error | ||
| | ^^^^^^^ | ||
| | A type declaration that has a permits clause should have a sealed modifier | ||
| -- Error: tests/neg/i18533/non-SCALA_ONLY.java:4:7 --------------------------------------------------------------------- | ||
| 4 |public non class Test { // error | ||
| | ^^^ | ||
| | Identifier 'non' is not allowed here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,4 @@ | |
| // Special test for the non-sealed trick (See JavaParsers.scala::modifiers) | ||
| public non class Test { // error | ||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| //> using javacOpt --enable-preview --source 17 | ||
| //> test: -jvm 17+ | ||
| // test: -jvm 17+ | ||
|
|
||
| package i18533; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| //> using javacOpt --enable-preview --source 17 | ||
| //> test: -jvm 17+ | ||
|
|
||
| package i18533; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| //> using javacOpt --enable-preview --source 17 | ||
| //> test: -jvm 17+ | ||
|
|
||
| package i18533; | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, we should only put one of them if tests are in a folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"historically", a "compilation group" for tests
foo_1.scala,bar_1.scalaget the same options because they are compiled together, so only one is needed per group. (Not sure if de-duplication is needed for anything.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to drop duplicate directives or raise an error if they're directives that contradicts each other.