-
Notifications
You must be signed in to change notification settings - Fork 1.1k
warn when running console instead of repl #19729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d510a4
to
cd52070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer a more "in your face" warning, but this works
Happy to change it to whatever. There are plenty of emojis. Or make it an error? |
I tried something like this maybe streams.value.log.warn(s"${BOLD}###################################################################$RESET")
streams.value.log.warn(s"${BOLD}# #$RESET")
streams.value.log.warn(s"${BOLD}# `console` uses the reference Scala version. Use `repl` instead. #$RESET")
streams.value.log.warn(s"${BOLD}# #$RESET")
streams.value.log.warn(s"${BOLD}###################################################################$RESET") |
cd52070
to
837272c
Compare
LGTM — I think the warning is better than an error, as it might still sometimes be handy to use Also yay ascii art. |
re #19174 (comment)