Fix dotr/dotc scripts

[OlivierBlanvillain]

This PR fixes the dotr/dotc scripts.

@felixmulder Do you have a better idea than the added line in .drone.yml? It looks a bit brutal, but this comment in Build.scala suggests that these tests need to be run in isolation.

[smarter]

Not super-nice, but you could do ;test;dotty-bin-tests/test

[felixmulder]

Yeah, I agree with Guillaume here - no need for this to be a separate process.

[felixmulder]

Would you mind adding a test that verifies correct behaviour on incorrect .packages file?

I believe that if we change versions, the .packages becomes invalid. Perhaps the clean command should also delete the .packages file?

[OlivierBlanvillain]

@felixmulder I know nothing of .packages, but I'm guessing this is not the "correct behaviour on incorrect .packages file":

$ bin/dotc
find: `/home/yolo/workspace/dotty/bin/../interfaces/target/dotty-interfaces-0.1.1-SNAPSHOT.jar': No such file or directory
find: `/home/yolo/workspace/dotty/compiler/target/scala-2.11/dotty-compiler_2.11-0.1.1-SNAPSHOT.jar': No such file or directory
find: `/home/yolo/workspace/dotty/bin/../library/target/scala-2.11/dotty-library_2.11-0.1.1-SNAPSHOT.jar': No such file or directory
find: `/home/yolo/workspace/dotty/library/target/scala-2.11/dotty-library_2.11-0.1.1-SNAPSHOT-tests.jar': No such file or directory
Error: Could not find or load main class dotty.tools.dotc.Main

[felixmulder]

So the scripts create a file called .packages in the root of the project with a format that the scripts read. If you delete the .packages file and re-run the script, it should create a valid one.

[OlivierBlanvillain]

@felixmulder something like this: ca6563a?

[felixmulder]

I would rather it intentionally corrupted the packages file so we can check that the find commands don't fail.

Would you mind working that into the test?

[felixmulder]

One option would be to screw with the version numbers in the packages file.

[OlivierBlanvillain]

I manually corrupted the file with sed -i s/olivier/yolo/g .packages and the script failed (this was #1957 (comment))

[OlivierBlanvillain]

@felixmulder ec1011a handls .package corruption

[felixmulder]

Very nice! @liufengyun - do you want to add your fixes to $HOME before we merge this?

[liufengyun]

@felixmulder : Sure, I think it's better to have that change in:

+      - ln -s /var/cache/drone/ivy2 $HOME/.ivy2
        - ./scripts/update-scala-library
-      - sbt -J-Xmx4096m -J-XX:ReservedCodeCacheSize=512m -J-XX:MaxMetaspaceSize=1024m -Ddotty.drone.mem=4096m -ivy /var/cache/drone/ivy2 "${TEST}"
+      - sbt -J-Xmx4096m -J-XX:ReservedCodeCacheSize=512m -J-XX:MaxMetaspaceSize=1024m -Ddotty.drone.mem=4096m "${TEST}"

@OlivierBlanvillain could you please add that?

[felixmulder]

The .drone.yml file needs to be signed using drone sign lampepfl/dotty on any changes

[OlivierBlanvillain]

$ drone sign lampepfl/dotty
Error: you must provide the Drone server address.
$ export DRONE_SERVER=dotty-ci.epfl.ch
$ drone sign lampepfl/dotty
Error: you must provide your Drone access token.