Skip to content

Use 3.4.0-RC2 for MiMa checks #19503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use 3.4.0-RC2 for MiMa checks #19503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ object Build {
* set to 3.1.3. If it is going to be 3.1.0, it must be set to the latest
* 3.0.x release.
*/
val previousDottyVersion = "3.4.0-RC1"
val previousDottyVersion = "3.4.0-RC2"

object CompatMode {
final val BinaryCompatible = 0
Expand Down
11 changes: 1 addition & 10 deletions project/MiMaFilters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,11 @@ object MiMaFilters {
val LibraryBackwards: Map[String, Seq[ProblemFilter]] = Map(
// In general we should never have backwards incompatible changes in the library.
// Only exceptional cases should be added here.
Build.previousDottyVersion -> Seq(
// This language feature was in 3.4.0-RC1 but will be removed in 3.4.0-RC2
ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language#deprecated.ascriptionVarargsUnpacking"),
ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$deprecated$ascriptionVarargsUnpacking$"),
)
Build.previousDottyVersion -> Seq.empty
)
val LibraryForward: Map[String, Seq[ProblemFilter]] = Map(
// Additions that require a new minor version of the library
Build.previousDottyVersion -> Seq(
// This language feature is not in 3.4.0-RC1 but will be added in 3.4.0-RC2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something broken in 3.4.0-RC2. The changes of #19316 where modified when backporting
https://github.com/lampepfl/dotty/pull/19316/files#diff-54406bedea7a8bfcd15a49467ca97594ae3c8ef3de104b0ebe5828d146b8ecd4R36
to
5fe047b#diff-54406bedea7a8bfcd15a49467ca97594ae3c8ef3de104b0ebe5828d146b8ecd4R36
This implies that we did not add the expected 3.5 language tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two ways to fix this

  1. We fix this and release a 3.4.0-RC3
  2. We do not fix it and revert temporarily (for 3.4.0) the 3.5 version from the main branch. Then we add it back when we decide to go to 3.5.

ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language.3.5-migration"),
ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language.3.5"),
ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$3$u002E5$"),
ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$3$u002E5$minusmigration$"),
)
)
val TastyCore: Seq[ProblemFilter] = Seq(
Expand Down