Skip to content

tweak: snippet compiler settings #19497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

i10416
Copy link
Contributor

@i10416 i10416 commented Jan 20, 2024

  • Fix build settings to make the snippet compiler to work properly
    • Before this change, snippet compiler read from library/scala instead of library/src/scala
  • Tweak some doc snippets so that they pass snippet compiker check

Related to: #12967

* Inferred(defn.RepeatedParamClass.typeRef.appliedTo(TypeRepr.of[Int]))
* Repeated(intArgs, TypeTree.of[Int]),
* Inferred(defn.RepeatedParamClass.typeRef.appliedTo(TypeRepr.of[Int]))
* )
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing )

- Fix build settings to make the snippet compiler to work properly
- Tweak some doc snippets so that they pass snippet compiker check

Related to: scala#12967
@i10416 i10416 force-pushed the docs/tweak-snippet-compiler-settings branch from cfa2671 to 438a17a Compare January 20, 2024 15:48
@Kordyjan Kordyjan requested a review from sjrd January 22, 2024 15:19
@sjrd sjrd merged commit 08a67b3 into scala:main Jan 23, 2024
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
WojciechMazur added a commit that referenced this pull request Jun 28, 2024
Backports #19497 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants