Introduce Tuple.ReverseOnto and use it in Tuple.reverse
#19183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
Dec 4, 2023
library/src/scala/Tuple.scala
Outdated
| type ReverseImpl[Acc <: Tuple, X <: Tuple] <: Tuple = X match | ||
| case x *: xs => ReverseImpl[x *: Acc, xs] | ||
| case EmptyTuple => Acc | ||
| type ReverseOnto[From <: Tuple, To <: Tuple] <: Tuple = From match |
There was a problem hiding this comment.
Should To be covariant? As with Concat.
There was a problem hiding this comment.
@sjrd do you have an opinion or suggestion on this?
nicolasstucki
force-pushed
the
step-towards-stabilizing-tuple-reverse
branch
from
41238f4 to
1dda4b3
Compare
nicolasstucki
force-pushed
the
step-towards-stabilizing-tuple-reverse
branch
from
1dda4b3 to
12e7c9e
Compare
sjrd
approved these changes
Dec 12, 2023
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Dec 14, 2023
These definition was updated in scala#19183. This does not leave much time to test before the release of 3.4. As a precaution we must delay it to 3.5.
nicolasstucki
added a commit
that referenced
this pull request
Dec 14, 2023
These definition was updated in #19183. This does not leave much time to test before the release of 3.4. As a precaution we must delay it to 3.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.