Fix type-mismatch confusion in types with simple name #19088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two failing tests:
Both fail because |
|
There's some further changes I might need to do to get it to compile, but thanks for the suggestion |
ausmarton
force-pushed
the
fix/i18678-type-mismatch-confusion-for-simple-types
branch
7 times, most recently
from
82ec1b5 to
7c0ff57
Compare
|
Took a bit longer than I thought it would and a few iterations, but the current version appears to be satisfying all the existing test expectations. |
ausmarton
commented
Nov 30, 2023
| @@ -88,7 +88,7 @@ object Message: | |||
| def followAlias(e1: Recorded): Recorded = e1 match { | |||
| case e1: Symbol if e1.isAliasType => | |||
| val underlying = e1.typeRef.underlyingClassRef(refinementOK = false).typeSymbol | |||
| if (underlying.name == e1.name) underlying else e1 | |||
| if (underlying.name == e1.name) underlying else e1.namedType.dealias.typeSymbol | |||
There was a problem hiding this comment.
@nicolasstucki dealiasing within PlainPrinter didn't seem to make a difference, but this seems to do the trick.
|
@ausmarton could you squash all commits into one? |
ausmarton
force-pushed
the
fix/i18678-type-mismatch-confusion-for-simple-types
branch
6 times, most recently
from
9d7419d to
792293d
Compare
ausmarton
force-pushed
the
fix/i18678-type-mismatch-confusion-for-simple-types
branch
from
792293d to
7480582
Compare
|
Sorry, I accidentally closed this Pull request. Will create a new one, as I'm unable to reopen this one |
nicolasstucki
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #18678