Fix #1905: Duplicate bridge #1906
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with scala#1905 was that we checked "new" overriding relationships are phase erasure + 1. This is wrong when we have ErasedValueTypes because these do not compare correctly ith their underlying type. So we get spurious mismatches which force in turn spurious bridge generation. The fix is to compute newly overridden symbols at phase elimErasedValueTypes + 1, i.e. one phase later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with #1905 was that we checked "new" overriding relationships
at phase erasure + 1. This is wrong when we have ErasedValueTypes because
these do not compare correctly with their underlying type. So we get spurious
mismatches which force in turn spurious bridge generation. The fix is to
compute newly overridden symbols at phase elimErasedValueTypes + 1, i.e. one
phase later.