Skip to content

Backport "Avoid crash in erasure when reference cannot be emitted" to LTS #19056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2023
Merged

Backport "Avoid crash in erasure when reference cannot be emitted" to LTS #19056

merged 2 commits into from
Dec 8, 2023

Conversation

Kordyjan
Copy link
Contributor

Backports #18056 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@Kordyjan Kordyjan changed the base branch from lts-17594 to lts-18116 November 28, 2023 14:56
@odersky @Kordyjan
Avoid crash in erasure when reference cannot be emitted
cee7df7 
Fixes #17391

[Cherry-picked 8231a48]
@odersky @Kordyjan
Compute the original qualifier type before erasure
8454909 
The original qualifier type was computed in the wrong context. For the logic
to make sense, it needs to compute the type before erasure and then erase that
type. That fixes #17391 by now compiling it correctly, the same way Scala 2 does.

[Cherry-picked 996bb15]
Base automatically changed from lts-18116 to release-3.3.2 December 8, 2023 15:18
@Kordyjan
Copy link
Contributor Author

Kordyjan commented Dec 8, 2023

No regressions detected in the community build up to lts-16941.

Reference

@Kordyjan Kordyjan merged commit 334e831 into release-3.3.2 Dec 8, 2023
@Kordyjan Kordyjan deleted the lts-18056 branch December 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kordyjan @odersky