-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Publish spec #18526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Publish spec #18526
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a49eeae
Use 3.4 as language version number in the spec.
sjrd 27c417c
Build the spec in the CI.
sjrd 1f31d84
Exclude useless files from the specification build.
sjrd a9baa5a
Deploy the spec on push.
sjrd 11df1e0
Add a disclaimer that the spec is still a work in progress.
sjrd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
name: Specification | ||
|
||
on: | ||
push: | ||
tags: | ||
- '*' | ||
branches-ignore: | ||
- 'gh-readonly-queue/**' | ||
pull_request: | ||
merge_group: | ||
workflow_dispatch: | ||
|
||
env: | ||
DOTTY_CI_RUN: true | ||
|
||
jobs: | ||
specification: | ||
runs-on: ubuntu-latest | ||
defaults: | ||
run: | ||
working-directory: ./docs/_spec | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
# Keep in sync with ./docs/_spec/Dockerfile | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: '2.7' | ||
- name: Install required gems | ||
run: | | ||
gem update --system | ||
gem install sass-embedded -v 1.58.0 | ||
gem install bundler:1.17.2 jekyll | ||
bundle install | ||
npm install bower | ||
|
||
- name: Build the specification | ||
run: | | ||
bundle exec jekyll build | ||
|
||
# Deploy | ||
- name: Deployment | ||
env: | ||
USER_FOR_TEST: ${{ secrets.SPEC_DEPLOY_USER }} | ||
if: ${{ env.USER_FOR_TEST != '' }} | ||
uses: burnett01/[email protected] | ||
with: | ||
switches: -rzv | ||
path: docs/_spec/_site/ | ||
remote_path: ${{ secrets.SPEC_DEPLOY_PATH }} | ||
remote_host: ${{ secrets.SPEC_DEPLOY_HOST }} | ||
remote_user: ${{ secrets.SPEC_DEPLOY_USER }} | ||
remote_key: ${{ secrets.SPEC_DEPLOY_KEY }} | ||
remote_key_pass: ${{ secrets.SPEC_DEPLOY_PASS }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# Keep in sync with relevant parts of .github/workflows/spec.yml | ||
|
||
FROM ruby:2.7 | ||
|
||
RUN apt-get install -y curl \ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be run on the publish of RC tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to publish on every merge, since it's still quite work-in-progress.