Skip to content

Deprecate Quotes {MethodType,TermParamClause}.isErased #18479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Deprecate Quotes {MethodType,TermParamClause}.isErased #18479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions library/src/scala/quoted/Quotes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2442,10 +2442,8 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
/** Is this a given parameter clause `(using X1, ..., Xn)` or `(using x1: X1, ..., xn: Xn)` */
def isGiven: Boolean
/** Is this a erased parameter clause `(erased x1: X1, ..., xn: Xn)` */
// TODO:deprecate in 3.4 and stabilize `erasedArgs` and `hasErasedArgs`.
// @deprecated("Use `hasErasedArgs`","3.4")
@deprecated("Use `hasErasedArgs` and `erasedArgs`", "3.4")
def isErased: Boolean

/** List of `erased` flags for each parameter of the clause */
@experimental
def erasedArgs: List[Boolean]
Expand Down Expand Up @@ -3226,10 +3224,8 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
/** Is this the type of using parameter clause `(implicit X1, ..., Xn)`, `(using X1, ..., Xn)` or `(using x1: X1, ..., xn: Xn)` */
def isImplicit: Boolean
/** Is this the type of erased parameter clause `(erased x1: X1, ..., xn: Xn)` */
// TODO:deprecate in 3.4 and stabilize `erasedParams` and `hasErasedParams`.
// @deprecated("Use `hasErasedParams`","3.4")
@deprecated("Use `hasErasedParams` and `erasedParams`", "3.4")
def isErased: Boolean

/** List of `erased` flags for each parameters of the clause */
@experimental
def erasedParams: List[Boolean]
Expand Down Expand Up @@ -4364,7 +4360,7 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
* - ...
* - Nth element is `FunctionN`
*/
@deprecated("Use overload of `FunctionClass` with 1 or 2 arguments","3.4")
@deprecated("Use overload of `FunctionClass` with 1 or 2 arguments", "3.4")
Copy link
Member

@bishabosha bishabosha Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR but this message seems ambiguous if we were to add another overload with 1 or 2 arguments, we might not catch it at the time those hypothetical methods would be added

def FunctionClass(arity: Int, isImplicit: Boolean = false, isErased: Boolean = false): Symbol

/** Class symbol of a function class `scala.FunctionN`.
Expand Down