throw error on ambiguous overload with methods and functions #18338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusildra
commented
Aug 7, 2023
Comment on lines
1505
to
1530
| case expr: TermRef if expr.widenSingleton.isInstanceOf[ExprType] => | ||
| tp.member(nme.apply).hasAltWith(d => p(TermRef(tp, nme.apply, d))) | ||
| case methRef: TermRef if methRef.widenSingleton.isInstanceOf[MethodicType] => | ||
| p(methRef) |
There was a problem hiding this comment.
Here. Because ExprType <: MethodicType, it would go on to p(methRef) without an apply "attached", and then fails in isApplicableMethodRef
iusildra
commented
Aug 8, 2023
iusildra
changed the title
|
It don't think it's necessary to update the comment at |
iusildra
force-pushed
the
i18294
branch
3 times, most recently
from
932bb1d to
49c56c9
Compare
|
The ticket is resolved as "not ambiguous". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18294
From what I saw, the compiler chose the method over the function in
Applications#narrowByTypes. That's because inApplications#isApplicationMethodRef()only aMethodTypecould give a success, so theFunction1was discarded and we could never reach the "ambiguous overloads" error