Skip to content

Fix BuildInfo scope in scala3-presentation-compiler, improve debugging support #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix BuildInfo scope in scala3-presentation-compiler, improve debugging support #18332

merged 2 commits into from
Aug 3, 2023

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Aug 2, 2023

No description provided.

@rochala rochala requested a review from adpi2 August 2, 2023 15:47
adpi2
adpi2 reviewed Aug 3, 2023
View reviewed changes
presentation-compiler/test/dotty/tools/pc/base/BasePCSuite.scala
@@ -51,7 +54,7 @@ abstract class BasePCSuite extends PcAssertions:
.newInstance("", myclasspath.asJava, scalacOpts.asJava)

protected def config: PresentationCompilerConfig =
PresentationCompilerConfigImpl().copy(snippetAutoIndent = false)
PresentationCompilerConfigImpl().copy(snippetAutoIndent = false, timeoutDelay = if isDebug then 3600 else 5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's smart. I'll use the idea in other projects :)

adpi2
adpi2 reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. But I think the documentation part should appear earlier.

adpi2
adpi2 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rochala rochala enabled auto-merge (squash) August 3, 2023 10:44
@rochala rochala added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Aug 3, 2023
@rochala
Copy link
Contributor Author

rochala commented Aug 3, 2023

This should be backported as package name is changed, and it will be easier to backport future changes in presentation compiler.

@rochala rochala merged commit 4dc1671 into scala:main Aug 3, 2023
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan mentioned this pull request Dec 1, 2023
Merged
Kordyjan pushed a commit that referenced this pull request Dec 1, 2023
@rochala @Kordyjan
Fix BuildInfo scope in scala3-presentation-compiler, improve debugg…
91082c4 
…ing support (#18332)

[Cherry-picked 4dc1671]
Kordyjan pushed a commit that referenced this pull request Dec 7, 2023
@rochala @Kordyjan
Fix BuildInfo scope in scala3-presentation-compiler, improve debugg…
c6bea3f 
…ing support (#18332)

[Cherry-picked 4dc1671]
Kordyjan pushed a commit that referenced this pull request Dec 7, 2023
@rochala @Kordyjan
Fix BuildInfo scope in scala3-presentation-compiler, improve debugg…
afecfad 
…ing support (#18332)

[Cherry-picked 4dc1671]
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "Fix BuildInfo scope in scala3-presentation-compiler, impr…
a3597e3 
…ove debugging support" to LTS (#19145)

Backports #18332 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
@tgodzik tgodzik added the area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rochala @adpi2 @tgodzik @Kordyjan