Warn on use of inferred quote type variable bounds #18195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
warn-on-use-of-inferred-quote-type-variable-bounds
branch
from
d2320ea to
4861162
Compare
nicolasstucki
force-pushed
the
warn-on-use-of-inferred-quote-type-variable-bounds
branch
from
4861162 to
42dee9f
Compare
|
Will need to rebase on #18199 |
nicolasstucki
force-pushed
the
warn-on-use-of-inferred-quote-type-variable-bounds
branch
from
42dee9f to
7fbd30b
Compare
This kind of inference is not reliable. We can only consider the bounds from type constructor where the type variable is defined but any other constraints are ignored. Therefore it is not possible to properly infer the type bounds of the type variable. The solution is simple, write the bounds explicitly and just check that those bounds conform to the use site of the type variable.
nicolasstucki
force-pushed
the
warn-on-use-of-inferred-quote-type-variable-bounds
branch
from
7fbd30b to
e47f798
Compare
nicolasstucki
added
the
needs-minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of inference is not reliable. We can only consider the bounds from type constructor where the type variable is defined but any other constraints are ignored. Therefore it is not possible to properly infer the type bounds of the type variable.
The solution is simple, write the bounds explicitly and just check that those bounds conform to the use site of the type variable. Unfortunately, this does not work yet with type quote pattern as we do not have SIP-53 yet. But in that case, we can also provide better warnings that mention the future support for the patterns they are trying to write.