Add missing parents to companions of case classes in stdlib-bootstrapped #18153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-missing-AbstractFunction1-partents
branch
5 times, most recently
from
aae006f to
3f0d899
Compare
SethTisue
changed the title
sjrd
reviewed
Jul 19, 2023
| else tp | ||
| case _ => tp | ||
|
|
||
| private def argTypeOfCaseClassThatNeedsAbstractFunction1(sym: Symbol)(using Context): Option[List[Type]] = |
There was a problem hiding this comment.
(TASTy) MiMa did not find cases with 2 or more arguments in the Scala 2 library.
| && !companionClass.primaryConstructor.is(Private) | ||
| && !companionClass.primaryConstructor.info.isVarArgsMethod | ||
| then | ||
| sym.info.decl(nme.apply).info match |
There was a problem hiding this comment.
None of the cases in the library are overloaded. This would need to be disambiguated if a new apply method is added to those objects.
sjrd
approved these changes
Jul 19, 2023
|
Needs a rebase. |
nicolasstucki
force-pushed
the
add-missing-AbstractFunction1-partents
branch
from
3f0d899 to
e0070d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.