Skip to content

Doc: ScalaSettings.scala - added period to option descriptions #18036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Doc: ScalaSettings.scala - added period to option descriptions #18036

merged 1 commit into from
Jun 30, 2023

Conversation

preveen-stack
Copy link
Contributor

  • added period to option descriptions where it was missing

@som-snytt
Copy link
Contributor

I don't know the policy here, but I just accidentally added a period to a Scala 2 message, where I think they decided to prefer no capitalization and no period, so it's just a clause. It would be nice if that were enforced by scalafix (or somehow). This is a common issue, also for Scaladoc.

@preveen-stack preveen-stack marked this pull request as ready for review June 22, 2023 04:21
@nicolasstucki
Copy link
Contributor

Need to rebase to make the tests pass

@preveen-stack @wide4head
Update ScalaSettings.scala
3714899 
- added period to option descriptions where it was missing
@preveen-stack preveen-stack force-pushed the correct-scala-settings-sentence-endings branch from 90c0140 to 3714899 Compare June 22, 2023 09:18
@preveen-stack
Copy link
Contributor Author

@nicolasstucki rebased and pushed

@Kordyjan Kordyjan merged commit b95c968 into scala:main Jun 30, 2023
@Kordyjan Kordyjan mentioned this pull request Nov 23, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "Doc: ScalaSettings.scala - added period to option descripti…
2f65661 
…ons" to LTS (#19052)

Backports #18036 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@preveen-stack @som-snytt @nicolasstucki @Kordyjan