Fix #1790: Change by-name pattern matching. #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New implementation following the scheme outlined in scala#1790.
This implements the rules laid down in scala#1805.
|
@DarkDimius please take a look at the changes in PatternMatcher of the last commit. I think I figured out how to determine the arity of the match in all cases, but it would be good to have this double-checked. |
|
LGTM, seems like the right way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation following the scheme
outlined in #1790.Update: The new set of rules is in #1805.
Review by @liufengyun, since it affects the pattern matcher.