refactor: some more scaladoc cleanup #17967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been moved in scala@c986fc5, but without any context. I can't see it referenced anywhere and I also see that it's actually in https://github.com/lampepfl/dotty/blob/d332059144b10102ca4d1c433d294309b43f1e51/scaladoc-js/main/src/searchbar/SearchbarComponent.scala#L105-L113, which makes me want to think this was never meant to be here. Testing locally this also seems to work just fine without this.
All of these files seem to be leftover from the migrations to scala3doc to being inside of the actual Dotty repo as they don't seem to be used or referenced in any way.
None of the other modules have their own gitignore so to avoid any confusion this just moves the single entry in the scaladoc one to the main one and then removes the scaladoc one.
Florian3k
approved these changes
Jun 16, 2023
Kordyjan
pushed a commit
that referenced
this pull request
Nov 17, 2023
This gets rid of some more stuff in scaladoc that doesn't seem to be used at all. You can see more details in each individual commit. [Cherry-picked d22d588]
Kordyjan
added a commit
that referenced
this pull request
Nov 21, 2023
Backports #17967 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of some more stuff in scaladoc that doesn't seem to be used at all. You can see more details in each individual commit.