Cache Match Alias applications and reductions, and ErrorType #17962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dwijnand
commented
Jun 12, 2023
dwijnand
commented
- ErrorType instead of throwing in match type "no cases"
- Cache applied match alias reductions
dwijnand
changed the title
Instead of throwing MatchTypeReductionError, return ErrorType(MatchTypeNoCases), which is a proper message as well. This avoids having to catch and ignore it as an exception. But it does require discovering it from type simplification and reporting it then - which replaces its reliance on catching TypeErrors. It also required handling scrutinees that are error types, which previously would always match the first case, due to FlexType semantics.
dwijnand
force-pushed
the
mt/refactor-reduction
branch
from
6dd94d0 to
dcc4d35
Compare
|
Haven't found definitive proof that caching is necessary, with other issues being fixed in other ways, so only keeping the first half in #18016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.