Fix #17667 account for import order #17951
Conversation
- Import in the same scope, but after the usage are reported. - Add test suit i17667 - Fix test i15503a
| import collection.mutable.Set // ok | ||
| import collection.mutable.Set // error |
There was a problem hiding this comment.
@szymon-rd
I was just wondering about this one, it seems like this import is not required. It can be removed and still get the correct result : https://scastie.scala-lang.org/9pyvzVWyTAyBsOPduePhqg
Am I missing something ?
There was a problem hiding this comment.
No, you are correct. Some of these tests lay out the expected false negatives. If this is not a false negative, then great.
| @@ -349,7 +348,7 @@ object CheckUnused: | |||
| * | |||
| * See the `isAccessibleAsIdent` extension method below in the file | |||
| */ | |||
| private val usedInScope = MutStack(MutSet[(Symbol,Boolean, Option[Name], Boolean)]()) | |||
| private val usedInScope = MutStack(MutSet[(Symbol,Boolean, Option[Name], Boolean, Option[SrcPos])]()) | |||
There was a problem hiding this comment.
Could you make it a case class instead? This tuple got very long and hard to understand.
|
@PaulCoral Can I finish this PR? Or are you planning to come back to it? |
|
@szymon-rd Yes, sure! Sorry for this, I was stuck with this last test, which seems to be related to "derives" (again...). I don't think I will have time soon for this, so you can go for it. |
|
I think this stale PR can be retired. Tracking imports by source position does not seem like a natural approach. |
|
Closing due to inactivity. |
Fix #17667
An example to illustrate this :
This compiles:
This does NOT compile