Spec: Syntax changes. #17943
Merged
Spec: Syntax changes. #17943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
spec-syntax-changes
branch
from
4434cdf to
a77595e
Compare
sjrd
force-pushed
the
spec-syntax-changes
branch
from
a77595e to
1e09225
Compare
bishabosha
reviewed
Jun 20, 2023
docs/_spec/01-lexical-syntax.md
Outdated
| ``` | ||
| as derives end extension infix inline opaque open transparent using | * + - | ||
| as derives end extension infix inline opaque |
There was a problem hiding this comment.
seems uncomfortably close
Suggested change
| as derives end extension infix inline opaque | |
| as derives end extension infix inline opaque |
bishabosha
reviewed
Jun 20, 2023
| ``` | ||
| Import ::= ‘import’ ImportExpr {‘,’ ImportExpr} | ||
| ImportExpr ::= SimpleRef {‘.’ id} ‘.’ ImportSpecifier | ||
| | SimpleRef `as` id |
There was a problem hiding this comment.
not seen SimpleRef on the lexical syntax page, but it is in the Types page
There was a problem hiding this comment.
Yes, that's normal. SimpleRef is a syntax-level non-terminal. The lexical syntax page only shows lexer-level tokens.
bishabosha
reviewed
Jun 20, 2023
| If a final wildcard `‘*’` is present, all non-`given` importable members ´z´ of ´p´ other than `´x_1, ..., x_n, y_1, ..., y_n´` are also made available under their own unqualified names. | ||
|
|
||
| Non-given import selectors work in the same way for type and term members. | ||
| For instance, an import clause `import ´p´.{´x´ => ´y´}` renames the term name `´p´.´x´` to the term name ´y´ and the type name `´p´.´x´` to the type name ´y´. |
There was a problem hiding this comment.
Suggested change
| For instance, an import clause `import ´p´.{´x´ => ´y´}` renames the term name `´p´.´x´` to the term name ´y´ and the type name `´p´.´x´` to the type name ´y´. | |
| For instance, an import clause `import ´p´.´x´ as ´y´` renames the term name `´p´.´x´` to the term name ´y´ and the type name `´p´.´x´` to the type name ´y´. |
bishabosha
approved these changes
Jun 20, 2023
This already includes `given` imports, although the rest of contextual abstractions are not there yet.
Because the change it describes was backported to Scala 2 and is already in the spec.
sjrd
force-pushed
the
spec-syntax-changes
branch
from
1e09225 to
cbf9d42
Compare
Kordyjan
added a commit
that referenced
this pull request
Dec 8, 2023
Backports #17943 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]