Skip to content

fix #1779: support $_ and $_id in interpolated string #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2016
Merged

fix #1779: support $_ and $_id in interpolated string #1780

merged 2 commits into from
Dec 15, 2016

Conversation

liufengyun
Copy link
Contributor

Fix #1779: support $_ and $_id in interpolated string.

Review @odersky .

@liufengyun liufengyun force-pushed the fix-i1779 branch 2 times, most recently from de26d42 to e9b9de4 Compare December 12, 2016 13:12
@odersky
Copy link
Contributor

odersky commented Dec 15, 2016

Allowing $_parent is technically a deviation from scalac's behavior. But I think your scheme is more consistent because we already allow underscores elsewhere in $-bound identifiers.

LGTM.

@odersky odersky merged commit 1773b37 into scala:master Dec 15, 2016
@allanrenucci allanrenucci deleted the fix-i1779 branch December 14, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liufengyun @odersky