Fix #1755: Make sure references in outer args are accessible #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed a fixup action in ExplicitOuter to avoid references to module's This from outside their scope. The problem is fixed, but I wish I understood better the root cause.
|
@DarkDimius Can you give it a shot to review? Thanks! |
|
I believe 15 days with two suggested reviewers is an unreasonable time to take for a review. Should we abandon the review system? |
|
Sorry for dropping the ball on this one, I should have asked for someone else to review it as soon as I was assigned since I was about to take a week off, I believe that the review system has proven extremely valuable in maintaining code quality and also in getting people acquainted with different part of the codebase. Anyway, LGTM, but I suggest opening an issue so that we remember to investigate why |
|
No worries. I am not sure about opening issues however. Right now I am
feeling like treading water. There's this deluge of issues coming in, but
unless I spend a huge amount of time personally on them they just seem to
pile up. So, unless we can bring more force to bear to actually fixing
issues, maybe we should just file the important ones?
…On Sat, Dec 17, 2016 at 7:10 PM, Guillaume Martres ***@***.*** > wrote:
Sorry for dropping the ball on this one, I should have asked for someone
else to review it as soon as I was assigned since I was about to take a
week off, I believe that the review system has proven extremely valuable in
maintaining code quality and also in getting people acquainted with
different part of the codebase. Anyway, LGTM, but I suggest opening an
issue so that we remember to investigate why fixThis is necessary.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1767 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAwlVqpC8QnoCu1e-ne3mNSEiR9Wmca3ks5rJCWPgaJpZM4LCYDI>
.
{"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/lampepfl/dotty","title":"
lampepfl/dotty","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/lampepfl/dotty"}},"
***@***.*** in #1767:
Sorry for dropping the ball on this one, I should have asked for someone
else to review it as soon as I was assigned since I was about to take a
week off, I believe that the review system has proven extremely valuable in
maintaining code quality and also in getting people acquainted with
different part of the codebase. Anyway, LGTM, but I suggest opening an
issue so that we remember to investigate why `fixThis` is
necessary."}],"action":{"name":"View Pull Request","url":"https://
github.com/lampepfl/dotty/pull/1767#issuecomment-267777729"}}}
--
Prof. Martin Odersky
LAMP/IC, EPFL
|
|
Sure, maybe what we need is a goal, like "get back the number of open issues under 200" and everyone tries to help? |
|
I think that's a good goal. Maybe exclude low-priority bugs and enhancement
propositions because these will inevitably pile up.
…On Sun, Dec 18, 2016 at 9:58 AM, Guillaume Martres ***@***.*** > wrote:
Sure, maybe what we need is a goal, like "get back the number of open
issues under 200" and everyone tries to help?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1767 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAwlVmZ-V8lo5v4BpMHvb2y45gwNc09Uks5rJPXSgaJpZM4LCYDI>
.
{"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/lampepfl/dotty","title":"
lampepfl/dotty","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/lampepfl/dotty"}},"
***@***.*** in #1767:
Sure, maybe what we need is a goal, like \"get back the number of open
issues under 200\" and everyone tries to help?"}],"action":{"name":"View
Pull Request","url":"https://github.com/lampepfl/dotty/
pull/1767#issuecomment-267810503"}}}
--
Prof. Martin Odersky
LAMP/IC, EPFL
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed a fixup action in ExplicitOuter to avoid references to
module's This from outside their scope.
The problem is fixed, but I wish I understood better the root cause.
Review by @smarter ?